Skip to content

Add Dummy device to migration#42

Merged
cfconrad merged 3 commits intowicked-nm-migrationfrom
dummy-device
Dec 13, 2023
Merged

Add Dummy device to migration#42
cfconrad merged 3 commits intowicked-nm-migrationfrom
dummy-device

Conversation

@jcronenberg
Copy link
Owner

@jcronenberg jcronenberg commented Nov 27, 2023 •
edited
Loading

Problem

No dummy device migration

Solution

Add dummy device migration

Fixes #24

Testing

  • Added a new integration test
  • Added a new unit test
  • Tested manually

@jcronenberg jcronenberg added enhancement New feature or request upstream Something needs to be changed/implemented upstream migration Something needs to be changed/implemented in the wicked migration labels Nov 27, 2023
@github-actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7166710965

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.9%) to 41.538%
Files with Coverage Reduction New Missed Lines %
rust/src/interface.rs 8 89.53%
Totals Coverage Status
Change from base Build 7165941261: 2.9%
Covered Lines: 81
Relevant Lines: 195
💛 - Coveralls

@jcronenberg
Copy link
Owner Author

jcronenberg commented Dec 8, 2023

Currently fails because upstream is missing dummy from is_ethernet(). Upstream PR agama-project#921

@jcronenberg jcronenberg force-pushed the dummy-device branch 2 times, most recently from 26af3f4 to 7b55973 Compare December 11, 2023 11:20
@jcronenberg jcronenberg marked this pull request as ready for review December 11, 2023 11:40
@jcronenberg jcronenberg requested a review from cfconrad December 11, 2023 11:40
@jcronenberg jcronenberg changed the title WIP: Add Dummy device to migration Add Dummy device to migration Dec 11, 2023
@jcronenberg jcronenberg marked this pull request as draft December 11, 2023 12:21
@jcronenberg jcronenberg marked this pull request as ready for review December 12, 2023 10:34
cfconrad
cfconrad approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfconrad cfconrad merged commit c19400a into wicked-nm-migration Dec 13, 2023
@jcronenberg jcronenberg deleted the dummy-device branch December 13, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfconrad cfconrad cfconrad approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request migration Something needs to be changed/implemented in the wicked migration upstream Something needs to be changed/implemented upstream

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Dummy

2 participants

@jcronenberg @cfconrad